cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] socklen_t fix attempt

From: Yang Tse <yangsita_at_gmail.com>
Date: Thu, 20 Dec 2007 05:19:08 +0100

2007/12/19, Daniel Stenberg wrote:

> [...] The .dist file is necesary since
> it makes sure there's a types.h present in release archives.
>
> In what ways is this still incomplete?

For systems capable of running configure its nearly finished. But in
think that in types.h.dist we also have to address systems that aren't
capable of running the configure script, and provided config files for
those might also need adjustments (amiga, msdos vms?). Inclusion of
types.h from curl.h

.cvsignore then shall ignore types.h. The release/snapshot process
should copy types.h.dist as types.h for all systems (I prefer leaving
this last one for you, I'll do the other ones)

> Is this method working fine if we try to install the headers when we build
> outside the source dir on a *nix box? I guess I need to check it out...

Don't know. I'll try this later today.

> > Should we go this route ?
>
> Do we have any other reasonable approach to select from? To me
> this seems like a doable way at least.

Even if we do this. socklen_t in the interface will hunt us back again
for some platform not capable of running the configure script. At
least we reduce the possibility.

-- 
-=[Yang]=-
Received on 2007-12-20