cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: patch for ssh user known_hosts

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 23 Oct 2007 12:47:09 +0200 (CEST)

On Mon, 22 Oct 2007, Johnny Luong wrote:

> I've attached a patch to curl to use the known_hosts file to determine
> whether to proceed with the ssh connection or not in my spare time. There
> are parts of it which aren't done, e.g: hostname matching, but it does work
> with the general case, e.g: exact domain or ip.

Cool!

Don't you think this code is better put within the libssh2 library rather than
in libcurl's code? I would assume other libssh2 users may like it as well!

A minor nit I noticed is the use of //-comments. Both libcurl and libssh2
strive for C89 compliance...

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2007-10-23