On 10/2/07, Dan Fandrich <dan_at_coneharvesters.com> wrote:
>
> On Mon, Oct 01, 2007 at 06:37:01PM -0700, Alexey Pesternikov wrote:
> > Ok, here we go.
> > See patch attached.
>
> Why not make struct Curl_sockaddr large enough to hold an IPv6 address to
> avoid having to play games with casting addr_storage[] etc. There are
> so many address structures already used within curl that it seems a shame
> to create yet another one that needs such tricks. You might as well use
> Curl_addrinfo in that case.

None of them is available in public interface (curl.h).
Curl_sockaddr_storage is in lib/sockaddr.h
And there is no easy way to move it to the curl.h because of
HAVE_STRUCT_SOCKADDR_STORAGE dependency.
Curl_addrinfo is in lib/hostip.h and it depends on CURLRES_IPV6 which in
turn depends on ENABLE_IPV6
We already discussed this earlier.

Otherwise, it looks good to me.

Thank you.

-- 
Alexey,
http://page2rss.com     RSS feed from almost any page