cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: patch to allow for ssh md5 checking option

From: Johnny Luong <johnny_at_trustcommerce.com>
Date: Tue, 02 Oct 2007 10:32:09 -0700

Daniel Stenberg wrote:
> On Tue, 2 Oct 2007, Daniel Stenberg wrote:
>
>> A question on the implementation. I find the loop with the "manual"
>> hexascii to numeric conversion a bit involved. Couldn't it just as
>> well simply be done with memcmp() or strncmp() ? You could even match
>> them case insensitively with Curl_strnequal()...
>
> Like the attached version. Comments?
>

I think your version makes more sense and its certainly cleaner from an
internal perspective. I wasn't actually at sure the time what APIs were
available to me internally (usually have the JavaDoc or some variant of
a manual next to me) and so I reverted back to doing a reimplementation.

-Johnny

Received on 2007-10-02