cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: EPSV and PASV Errors from Dreamhost

From: Jofell Gallardo <jofell_at_xackup.org>
Date: Wed, 18 Jul 2007 06:23:50 +0800

On 7/18/07, Daniel Stenberg <daniel_at_haxx.se> wrote:
>
> On Tue, 17 Jul 2007, Jofell Gallardo wrote:
>
> > I'm actually a fan of yours when it comes to support... you're like
> superman
> > for mailing lists...
>
> Thanks!
>
> > * control connection looks dead
> > * Connection #0 to host crackerjack.dreamhost.com left intact
>
> While I share Dan F's views on this not being the full log, I believe the
> above two lines reveal a bug! When the control connection "seems dead", we
> should not re-use that in a subsequent request!

I'm really sorry if I sounded stubborn or something. What I meant by "full
log" was that was the only
logs my customer gave me. He told me that was the start of the verbose part
of the curl (I was quite
startled he knows stuff like this). Anyway, my apologies, and next time,
I'll be giving them all.

I'll commit the change below, that may make your case behave differently:
>
> --- lib/ftp.c 13 Jul 2007 20:04:53 -0000 1.419
> +++ lib/ftp.c 17 Jul 2007 20:27:36 -0000
> @@ -3137,7 +3137,7 @@
> if(!nread && (CURLE_OPERATION_TIMEDOUT == result)) {
> failf(data, "control connection looks dead");
> ftpc->ctl_valid = FALSE; /* mark control connection as bad */
> - return result;
> + conn->bits.close = TRUE; /* mark for closure */
> }
>
> if(result)

Way too cool! Can't wait to use this patch. Umm... one question though. Was
this fix already on
versions > 7.16.1? Or is this the real deal fix (like nothing committed yet
to stable)? Nothing biggie...
just ecstatic you guys are doing great work!
Received on 2007-07-18