cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Re: http proxy tunnel, connect-only and authentication

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 12 Jul 2007 00:28:50 +0200 (CEST)

On Wed, 11 Jul 2007, Shmulik Regev wrote:

> While debugging enough time passed (I had coffee or
> something :) which caused Curl_connecthost to fail on a timeout (i.e.
> CURLE_OPERATION_TIMEOUTED is returned). This in turn caused an endless
> loop in SetupConnection (as the condition
> conn->bits.proxy_connect_closed stays true).

I think the keeping if the conn->bits.proxy_connect_closed set to true is the
_actual_ problem here. It should probably be assigned to false unconditionally
in the beginning of ConnectPlease() or similar.

Won't that too fix the problematic case you experienced?

Like this:

diff -u -r1.625 url.c
--- lib/url.c 11 Jul 2007 09:03:22 -0000 1.625
+++ lib/url.c 11 Jul 2007 22:28:51 -0000
@@ -4070,6 +4070,7 @@
      return result;
    }
    *protocol_done = FALSE; /* default to not done */
+ conn->bits.proxy_connect_closed = FALSE;

    /*************************************************************
     * Set user-agent for HTTP

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2007-07-12