cURL / Mailing Lists / curl-library / Single Mail



From: James Housley <>
Date: Mon, 18 Jun 2007 08:22:59 -0400

On Jun 18, 2007, at 7:14 AM, Daniel Stenberg wrote:

> Hi James,
> The PATH_MAX usage in lib/urldata.h still breaks builds and I
> hesitate to release until we have this sorted.

Really, ok. It is used elsewhere in the system, but I was the first
to add it to the .h

> Also, I've taken a look at this and I think we should reconsider
> the use of this define:
> It is by default set to 4096 on many systems, and having two
> variables of that size by default in a struct is needlessly gonna
> add some 8K of memory use for every single connection (for libcurls
> with SSH-capabilities enabled). I think we should rather malloc-on-
> demand instead.

OUCH, I know it is 1024 on some systems I have access to. But 8K is
a bit large.

> I think the asprintf() function should come handy for this.
> So what do you think about this?

The change looks like it isn't too hard. Today being Monday is not
good. I can do it later this afternoon (Eastern US).


/"\   ASCII Ribbon Campaign  .
\ / - NO HTML/RTF in e-mail  .
  X  - NO Word docs in e-mail .
/ \ -----------------------------------------------------------------
                 The Power to Serve
In theory there is no difference between theory and practice.
In practice there is no similarity.
       -- From the "I wish I'd said that" archives.
Received on 2007-06-18