cURL / Mailing Lists / curl-library / Single Mail

curl-library

last Curl_select() improvements

From: Yang Tse <yangsita_at_gmail.com>
Date: Tue, 29 May 2007 17:58:32 +0200

Regarding http://cool.haxx.se/cvs.cgi/curl/lib/select.c.diff?r1=1.44&r2=1.45

Good catch using malloc() instead of calloc() and the earlier loop break out.

On the other hand, using an intermediate var 'events' instead of
directly using 'poll_fds[ix].events' triggers warnings related with
the different size of those vars.
http://curl.haxx.se/auto/log.cgi?id=20070529091619-28942#prob1 No
typecasting will get rid of that warning since different platforms use
different sizes for the events and revents fields of the 'pollfd'
struct.

I know that this is like comparing apples with oranges. Does the speed
improvement the intermediate var introduces outweight the compiler
warning it also introduces?

-- 
-=[Yang]=-
Received on 2007-05-29