curl-library
Re: patch for VMS build
Date: Tue, 24 Apr 2007 17:11:42 +0100
Thanks for the pointers (no pun intended)
Attached is a revised patch, making sure all the relevant changes are
wrapped in #ifdef VMS and i've modified the #if __INITIAL_POINTER_SIZE
to make them more appropriate (and accurate)
Let me know if there are any more issues...
Thanks,
Steve
On 4/24/07, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Mon, 23 Apr 2007, Dan Fandrich wrote:
>
> > On Mon, Apr 23, 2007 at 01:21:33PM -0400, Steve Little wrote:
> >> + #if __INITIAL_POINTER_SIZE
> >> + #pragma pointer_size save
> >> + #pragma pointer_size short
> >> + #pragma message disable PTRMISMATCH
> >> + #endif
> >
> > These sections ought to have comments saying that they're for VMS only or
> > better yet be enclosed in an #ifdef VMS block so it's clear what they're
> > there for.
>
> Also, you probably want #ifdef there and not #if for the cases where
> __INITIAL_POINTER_SIZE isn't defined at all - to avoid picky compiler
> warnings. Possibly, both a check for it being defined and being > 0 if that
> truly is what you need for this to evaluate true.
>
> --
> Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
>
- text/plain attachment: curldiff.patch2