cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Patch to send arbitrary SFTP commands

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 1 Apr 2007 23:42:24 +0200 (CEST)

On Sun, 1 Apr 2007, Nick Zitzmann wrote:

> Sorry if I'm being a bother, but did any of the developers get the patch?

All devs subscribe to this list, so yes we all got it. Please be patient.

Did you really test this version with all the commands? It seemed to be using
curl_strnequal() wrong in several places and "rm" would always match before
"rmdir", effectively preventing the latter from ever getting used.

I addressed all these issues, and made the code a lot more compact with less
multiple identical code sections and exact parsing of commands (by including
the separating space in the string comparison).

I also made it use the curl-style of indenting all over.

I didn't however actually try this on a live server, so I would be very happy
if you or someone else could try the attached patch and verify that it still
works, or if I broke something, please fix it and re-submit and updated
version.

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html

Received on 2007-04-02