curl-library
Re: Patch to send arbitrary SFTP commands
Date: Thu, 29 Mar 2007 11:01:52 +0200 (CEST)
On Wed, 28 Mar 2007, Nick Zitzmann wrote:
Thanks for your patch!
> The commands supported are chown, chmod, chgrp, ln/symlink, mkdir, rm, and
> rmdir.
No rename?
> I borrowed some parsing code from OpenSSH, which uses the BSD license. I
> hope that's OK...
Yes, this is the Modified BSD so it is fine.
Some remarks on the patch itself:
o indentation and (no) TAB usage is not following libcurl standard
o use less than 80 columns source code width
o the quote errors could be set with failf() to provide a better human
error message
o use memset() instead of bzero()
o use strnequal() instead of strncasecmp() - but are the commands really
meant to be case insensitive?
Also, could you please consider providing at least some rudimentary docs for
the commands supported and how to use them?
-- Commercial curl and libcurl Technical Support: http://haxx.se/curl.htmlReceived on 2007-03-29