cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: NTLM proxy nightmare - POST problem?

From: Jonathan Arnold <jarnold_at_insors.com>
Date: Thu, 15 Mar 2007 10:09:38 -0400

Daniel Stenberg wrote:
> On Fri, 9 Mar 2007, Jonathan Arnold wrote:
>
>> As a test, I just took out the '(expectsend == -1) ||' test found in
>> http.c, line 256. This seems to work okay in all cases (NTLM proxy,
>> Basic Proxy and no proxy). I have no idea why that test is in there,
>> as a -1 expectsend seems to imply there's nothing to send, yet the if
>> is trying to do sending. I don't really know what it is trying to do,
>> exactly, but it seems to work.
>
> To make the change you did really clear to me, can you please post a
> diff -u output for it?

Here's what it is, but like I said in a later email, it won't really fix
the problem if the POSTFIELDSIZE is set. It will still go into the if and
then get into a bad state after that.

--- http.c 2007-03-15 10:08:02.937500000 -0400
+++ ../../curl/curl/lib/http.c 2007-02-25 23:24:26.000000000 -0500
@@ -253,7 +253,7 @@

    conn->bits.rewindaftersend = FALSE; /* default */

- if( (expectsend > bytessent)) {
+ if((expectsend == -1) || (expectsend > bytessent)) {
      /* There is still data left to send */
      if((data->state.authproxy.picked == CURLAUTH_NTLM) ||
         (data->state.authhost.picked == CURLAUTH_NTLM)) {

-- 
Jonathan Arnold           Software Engineer
inSORS Integrated Communications, Inc
jarnold_at_insors.com Office/fax: 781.391.2818
Received on 2007-03-15