On Nov 10, 2006, at 4:21 PM, Daniel Stenberg wrote:

> On Thu, 9 Nov 2006, James Housley wrote:
>
>> I made some progress on sftp.
>> * File can be uploaded
>> * The directory listing can be gotten
>>
>> I am having problems getting a remote file I open the file, but I
>> need to figure out how to have data start coming.
>
> How come you need a separate Curl_sftp_connect() that seems to
> repeat a great deal of what Curl_scp_connect() also does? Won't it
> make sense to have these two call a generic "ssh_connect()"
> function for all the general SSH stuff and then only do the little
> differences in the Curl_sftp_connect() and Curl_scp_connect()
> functions?

They probably be merged. How will I tell which it is? (conn-
>protocol & PROT_SFTP) ?
>
> I have an idea regarding the dir listing. We could reuse the
> CURLOPT_FTPLISTONLY option and allow a plain "list all dir entries
> only". For the "normal" case we should probably output the dir in
> an easily parsed format (parsed by software that is).

Okay. The format I choose is as close to the standard FTP dir
listing as I could make. I will add support for that option.

>
> PS, when it is a simple and single patch you attach, please don't
> zip it but send it attached "plainly" since it makes it a lot
> easier to read the patch directly from within mail programs or when
> browsing this list archive on the web!

True, it is now just a single file.

Jim

--
/"\   ASCII Ribbon Campaign  .
\ / - NO HTML/RTF in e-mail  .
  X  - NO Word docs in e-mail .
/ \ -----------------------------------------------------------------
jeh@FreeBSD.org      http://www.FreeBSD.org     The Power to Serve
jim@TheHousleys.Net  http://www.TheHousleys.net
---------------------------------------------------------------------
Q: Because it reverses the logical flow of conversation.
A: Why is putting a reply at the top of the message frowned upon?