cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: conn->proto.ftp == NULL in Curl_ftp_done

From: Armel Asselin <asselin.armel_at_wanadoo.fr>
Date: Mon, 18 Sep 2006 10:12:02 +0200

>> because my problems come when 'pwd' is missing (leaving "armel:@", it
>> seems that libcurl then tryies to resolve 'armel' as server and '@192...'
>> as port or something like that)
>
> Sounds like a bug, but test case 264 actually verifies that this works,
> and it runs fine for me.
but the test case does not test for my armel:@ case :(
and it actually fails if the password is empty.

the following code (near url.c:3298) :

if(2 == sscanf(proxyptr,
        "%" MAX_CURL_USER_LENGTH_TXT"[^:]:"
        "%" MAX_CURL_PASSWORD_LENGTH_TXT "[^@]",
        proxyuser, proxypasswd)) {

seems to be the problematic code: The test should be '1 <=' rather than '2
==' (and setting proxypasswd[0]=0; before), it seems that sscanf rejects an
empty string as a possibility for "%" MAX_CURL_PASSWORD_LENGTH_TXT "[^@]".

Armel
Received on 2006-09-18