On Jan 16, 2006, at 5:21 PM, Daniel Stenberg wrote:

> On Mon, 16 Jan 2006, David Shaw wrote:
>
>> Sure, here you go.
>>
>> Note that test222 mentions gopher, but I couldn't remove this as
>> it would invalidate the test. It's just text there anyway.
>
> Right, you'd need to redo the base64 encoded chunk as well so let's
> keep it there. As you said, it is only text for the test case.
>
>> Also note I didn't renumber the PROT_* flags in lib/urldata.h to
>> fill in the hole that removing PROT_GOPHER caused. I wasn't sure
>> if the actual values were needed somewhere.
>
> They're not, but having a gap in there don't make any difference
> either so that's fine.
>
> Thanks a lot! I applied and committed this cleanup sweep just now.
>
> --
> Commercial curl and libcurl Technical Support: http://haxx.se/
> curl.html

Won't removing renumbering cause problems if the library and .h are
slightly out of sync? Wouldn't it be better for correctness to leave
a gap?

Jim

--
/"\   ASCII Ribbon Campaign  .
\ / - NO HTML/RTF in e-mail  .
  X  - NO Word docs in e-mail .
/ \ -----------------------------------------------------------------
jeh@FreeBSD.org      http://www.FreeBSD.org     The Power to Serve
jim@TheHousleys.Net  http://www.TheHousleys.net
---------------------------------------------------------------------
In theory there is no difference between theory and practice.
In practice there is no similarity.
       -- From the "I wish I'd said that" archives.