cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: tld_check_name and IDNA

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 14 Dec 2005 20:27:40 +0100 (CET)

On Wed, 14 Dec 2005, Dan Fandrich wrote:

> I've added a curl autobuild with the lcc compiler, and it came up with a
> warning on the use of tld_check_name() in fix_hostname() in url.c that looks
> like it might be a problem. tld_check_name() returns a bool, has one const
> parameter and one non-const parameter that is used only incidentally, and
> doesn't appear to have any side effects. It is called once but the returned
> value is ignored, so I don't see that it ends up doing anything useful.
> What is it supposed to be doing?

Good catch!

Uhm, it looks like we should require that to return TRUE or otherwise bail
out as then the host name contains letters not allowed.

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2005-12-14