cURL / Mailing Lists / curl-library / Single Mail

curl-library

New overnight build changes

From: Dan Fandrich <dan_at_coneharvesters.com>
Date: Wed, 16 Mar 2005 14:18:09 -0800

The new test 237 is showing some problems on Tru64. Tru64
V5.1 resolves 1218.91.256.127 as 194.91.0.127 (i.e.
(1218&0xff).(91&0xff).(256&0xff).(127&0xff)) and therefore a different
error code than normal systems because it actually tries to connect to that
bogus address. It seems to be a bug in Tru64's inet_addr() function. On
a related note, my man page for inet_addr(3) says that inet_addr is
deprecated and inet_aton(3) should be used instead. That's probably
not going to help here, though.

Netware builds are performed differently now. Compare for example
  http://curl.haxx.se/auto/log.cgi?id=20050316142805-22023
with yesterday's version:
  http://curl.haxx.se/auto/log.cgi?id=20050315142555-20292
It appears that the "target=netware" parameter is being ignored in the
testbuild.pl script.

It would be nice to disable valgrind when using testcurl.pl. This patch
will do it by allowing you to add a option like
--maketestopts="TEST_F='\$(TEST) -a -p -n\'" when running testcurl. It's
a generic solution that works, but it's tied to the structure of the makefiles.
The alternative would be separate options for each variable
(--disable-valgrind, --torture-test, etc.).

Index: tests/testcurl.pl
===================================================================
RCS file: /cvsroot/curl/curl/tests/testcurl.pl,v
retrieving revision 1.24
diff -u -r1.24 testcurl.pl
--- tests/testcurl.pl 15 Mar 2005 12:13:37 -0000 1.24
+++ tests/testcurl.pl 16 Mar 2005 21:49:24 -0000
@@ -43,6 +43,7 @@
 # --crosscompile This is a crosscompile
 # --desc=[desc] Description of your test system
 # --email=[email] Set email address to report as
+# --maketestopts=[options] Options to include on "make test-full" command
 # --mktarball=[command] Command to run after completed test
 # --name=[name] Set name to report as
 # --nocvsup Don't update from CVS even though it is a CVS tree
@@ -62,7 +63,7 @@
 use vars qw($version $fixed $infixed $CURLDIR $CVS $pwd $build $buildlog
             $buildlogname $configurebuild $targetos $confsuffix $binext
             $libext);
-use vars qw($name $email $desc $confopts $setupfile $mktarball $nocvsup
+use vars qw($name $email $desc $confopts $maketestopts $setupfile $mktarball $nocvsup
             $crosscompile);
 
 # version of this script
@@ -104,6 +105,9 @@
     $crosscompile=1;
     shift @ARGV;
   }
+ elsif ($ARGV[0] =~ /--maketestopts=/) {
+ $maketestopts = (split(/=/, shift @ARGV, 2))[1];
+ }
   else {
     $CURLDIR=shift @ARGV;
     $CVS=0;
@@ -517,8 +521,8 @@
 }
 
 if ($configurebuild && !$crosscompile) {
- logit "run make test-full";
- open(F, "make test-full 2>&1 |") or die;
+ logit "run make $maketestopts test-full";
+ open(F, "make $maketestopts test-full 2>&1 |") or die;
   open(LOG, ">$buildlog") or die;
   while (<F>) {
     s/$pwd//g;

>>> Dan

-- 
http://www.MoveAnnouncer.com              The web change of address service
          Let webmasters know that your web site has moved
Received on 2005-03-16