On Sun, 13 Feb 2005, Martin Paljak wrote:

(not replying to opensc-devel, this is libcurl-specific)

Thanks for your work and patch! Don't let my comments below make you doubt
that I appreciate your efforts.

> The quick patches should describe themselves.

I disagree. I know very little about these things, so even if the changes
themselves might be clear, I don't know what the purpose if the whole thing is
and I want new options documented properly when added to libcurl. (That goes
for new options to the curl command line tool as well.)

> More error checking etc could be done.

So I take it you will work on an updated patch?

Also, a few nits/questions on the patch:

- on the mod of the SessionHandle struct: you should add new options
   that an app sets to the 'struct UserDefined' struct, not the 'struct
   DynamicStatic' one. It is important to get things like curl_easy_duphandle()
   to work, and to maintain consistency with existing code.

- +#define HAVE_ENGINE_LOAD_BUILTIN_ENGINES 1
   This is clearly a mistake

- I see you strcmp() the engine name for "dynamic" to see if this is
   activated. Isn't it better to rely on one of the options you
   added that is bound to be set when this is used? Like SSLENGINE_ID. If not,
   is it really sane and safe to just allocate an engine name to check for
   this?

-- 
      Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se
       Dedicated custom curl help for hire: http://haxx.se/curl.html