cURL / Mailing Lists / curl-library / Single Mail

curl-library

[PATCH] unused rkeepfd and wkeepfd

From: Dan Torop <dtorop933_at_gmail.com>
Date: Tue, 11 Jan 2005 13:49:27 -0500

In the Curl_transfer_keeper structure, rkeepfd and wkeepfd are set but
no longer used. This appears to have happened since David Phillips'
FD_SETSIZE fix for bug #948950 (creation of Curl_select() and
Curl_poll() in lib/select.c) was checked in on 11/19/04.

Attached is a (trivial) patch to no longer store or set these
variables. This is only in the name of cleaning code. Please let me
know if this is of any use and doesn't break anything...

Incidentally, I got interested in this trying to understand PHP bug
26332. David Phillips' patch seems to have solved this bug, but I
still don't understand if the bug was in PHP, libcurl, or was entirely
incidental. (Should probably write regarding that to curl-and-php
list, sorry for off-topic.)

Thanks very much,

Dan

Received on 2005-01-11