curl-library
Re: curl random file and configure (fwd)
From: Daniel Stenberg <daniel-curl_at_haxx.se>
Date: Thu, 9 Dec 2004 10:35:36 +0100 (CET)
Date: Thu, 9 Dec 2004 10:35:36 +0100 (CET)
Hi peeps
Below is a single mail taken from a private discussion between me and Dan
Fandrich. I'm forwarding it here with his permission.
I feel a bit swamped right now so while I consider the remarks below valid, I
don't think I'll have much time or energy to clean up these matters right now.
Of course I'll accept patches that do the work
Dan, you could resend your patch to the list to let people see what we
discuss.
-- Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se Dedicated custom curl help for hire: http://haxx.se/curl.html ---------- Forwarded message ---------- Date: Wed, 8 Dec 2004 16:59:49 -0800 From: Dan Fandrich <dfandrich_at_intrinsyc.com> To: Daniel Stenberg <daniel_at_haxx.se> Subject: Re: curl random file and configure On Thu, Dec 09, 2004 at 12:00:07AM +0100, Daniel Stenberg wrote: > That complexity is in fact already in the configure script. The > OPENSSL_ENABLED variable gets set to 1 when the script considers there's a > valid OpenSSL enabled. You could use that variable as a pre-condition for the > random file check. Won't that be better? That would be better, but I'm a bit confused as to the relationships between all the (very closely related) variables. In configure there are defined: OPT_SSL HAVECRYPTO OPENSSL_ENABLED in setup.h are defined: USE_SSLEAY USE_OPENSSL plus there are a bunch in config.h.in like: HAVE_LIBSSL HAVE_LIBCRYPTO and all the header file ones. Can these be unified? Perhaps configure should export USE_SSLEAY and USE_OPENSSL to replace the internal OPENSSL_ENABLED, which would clean up setup.h, too. > I'll wait with applying to let you either move the check and post a new patch, > or just tell me things are fine as they are when your current patch is > applied. Feel free to cc: this to the libcurl mailing list if you want wider exposure. >>> DanReceived on 2004-12-09