curl-library
Re: connect error reporting
Date: Wed, 12 May 2004 12:51:47 +0200
Did this patch got stuck somewhere?
An updated patch attached.
----- Original Message -----
From: "Gisle Vanem" <gvanem_at_broadpark.no>
To: "curl-library" <curl-library_at_cool.haxx.se>
Sent: Friday, May 07, 2004 10:55 PM
Subject: connect error reporting
> libcurl now reports failed connections on Windows as:
> * Connect failed; No error
>
> "No error" comes from the sclose() call since errno's on
> Windows doesn't work as on Unix (where errno is only set
> on failure).
>
> AFAICS, since connect() is non-blocking, the error must be
> obtained from getsockopt(..SO_ERROR), but verifyconnect()
> doesn't do this on Windows. Not sure why that is ifdef'ed out,
> but that function works fine here.
>
> Attached is a little patch that gives correct error response.
> Also a minor detail for ldap.[ch]; no Curl_ldap_done().
>
> --gv
>
- text/plain attachment: diffs.txt