cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Some patches

From: Daniel Stenberg <daniel-curl_at_haxx.se>
Date: Wed, 5 May 2004 14:49:23 +0200 (CEST)

On Wed, 5 May 2004, Gisle Vanem wrote:

> progress.c; fixed the percent values being trunced to 0.
> if we don't use doubles the percent calculation could overflow in
> the X*100 step. But I assume it's safe if curl_off_t is 64-bits.

Yes, but only then. With this patch, systems with 32bit file sizes will get a
math overflow when ~40MB (2^32/100) has been transfered and then the
percentage will be much more wrong than it is today...

-- 
     Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se
      Dedicated custom curl help for hire: http://haxx.se/curl.html
Received on 2004-05-05