Joe Halpin wrote:
> Daniel Stenberg wrote:
>
>> On Sun, 21 Mar 2004, Joe Halpin wrote:
>
>
>> I approve of the idea and the concept. I have only a few minor nits on
>> the
>> patch:
>>
>> 1. I'd rather see a new command line option than an environment
>> variable for
>> the command line tool (perhaps called --tcp-nodelay).
>>
>> 2. Instead of duplicating 5 lines of code, I'd prefer to have the
>> actual code
>> that do the setsockopt() call put into a separate function, and call
>> that function from two places (the ipv4 code and the ipv6 code).
>>
>> 3. errno is not set on windows for network related stuff as one would
>> think,
>> use Curl_ourerrno() to get a portable errno. (used if the
>> setsockopt() call
>> returns failure)

errp, I missed 3.

You can #ifdef the error message out for Windows if you want, or let me
know and I'll submit another patch. I'm going to bed right now as I'm
clearly being overcome by pollen at this point.

Joe
Received on 2004-03-25