cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] AIX compilation error

From: Tor Arntsen <tor_at_spacetec.no>
Date: Wed, 10 Mar 2004 12:23:44 +0100

On Mar 9, 22:28, Daniel Stenberg wrote:
TA>> xlc -DHAVE_CONFIG_H -I. -I../../../curl/tests/server -I../../lib -I../../src -I../../../curl/lib -DCURLDEBUG -g -g -c ../../../curl/tests/server/sws.c
TA>> "../../../curl/lib/setup.h", line 142.10: 1506-296 (S) #include file <curl/stdcheaders.h> not found.
TA>> make[2]: *** [sws.o] Error 1
TA>> make[2]: Leaving directory `/users/tor/curl-build/build-23376/tests/server'
TA>>
TA>> Fix follows below.
>
>I applied and committed your fix just seconds before I realized why this error
>occurs: the sws build doesn't have an include path that points to the
>source-tree include/ dir.

That is true, and if there are any architectures out there that don't have
stdcheaders then that include path will have to be fixed I guess.
But I didn't want to fix this particular build problem that way because it
would still be incorrect to include stdcheaders.h for AIX. The code that
my patch removed was wrong (seems to have been there since 2002 or so).

>But if everything still builds fine with this fix committed, I guess it was
>still a good fix!

I think so for sure, but then again I'm biased :-)

-Tor
Received on 2004-03-10