cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: ssl callback

From: Peter Sylvester <Peter.Sylvester_at_EdelWeb.fr>
Date: Tue, 20 May 2003 16:41:56 +0200 (MET DST)

> >
> > > the url send an http host can be the full URL. I tried to set the ppath
> > > unconditionally, the code works.
> >
> > No. The path used a GET line to a typical HTTP server shall not be the full
> > URL, only the path part. Only proxies get the full URL in there. Your test
> > server might not complain, but we cannot do that serious violation against
> > the RFC. Others will not appreciate that.
>
> HTTP 1.1 servers MUST accept the absoluteURI. See page 37 of RFC 2616.
>
> I can add some logic that tests whether after the
> conn->ppath calculation the url had been changed or whether
> the version string is 1.1
>
> The suggested solution is to just avoid a recalculation of
> conn->ppath whenever one sets a URL.

Daniel,

I followed your suggestion of running the tests :-) This motivated
me to add the following logic:

  Whenever a CURL_OPT_URL is called, i.e. when data->change.url is
  modified, then a flag is set, reset when the conn->ppath
  is derived.

  if someone is doing a CURL_OPT_URL during the connection, it
  seems to me that one should assume that the server behind is
  really 1.1 compliant, i.e. MUST understand absoluteURI.

Another logic would be not to set the conn->ppath at connection
setup but to create it in http.c when it is actually needed but
this is a little bit more than a small fix (at leastv for me).

Peter

-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge
Received on 2003-05-20