Hi,

Is the following behavior for the Curl_connecthost function in the
connect.c (latest CVS) file correct?

rc = waitconnect(sockfd, timeout_ms);

if(-1 == rc) {
    /* no good connect was made */
    sclose(sockfd);
    *sockconn = -1;
    return CURLE_COULDNT_CONNECT;
  }

Given that waitconnect() returns a non-zero value if there isn't a good
connect, it would be better to do

  if(0 != rc) {

I'll do some testing and I will post a patch if this is indeed a bug.

Regards,
-sm
Received on 2001-10-28