cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: bug in curl_easy_perform

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 23 Aug 2001 15:55:59 +0200 (MET DST)

On Thu, 23 Aug 2001, T. Bharath wrote:

> Now the solution is to reset it at the begginning or the end of
> Curl_perform

Thanks a lot for digging, reporting and for providing a solution. I would
however not go with that exact solution...

If we would reset the flag in the beginning of the _perform function, then
we'd leak the memory that is possibly still allocated and pointed to by the
data->url pointer.

If we would do it in the end of the function, well then we would risk that
_perform() is re-invoked with a data->url pointer that is illegal (or NULL).

I think it should be done where data->url is (re-)set and of course in the
curl_easy_cleanup(). It is already done in the later.

I'll add the fix right now.

> But my question here is are there any other bits,variables that need to
> be reset

Well, if there are, they too are mistakes and have fallen through my checks.

-- 
    Daniel Stenberg -- curl groks URLs -- http://curl.haxx.se/
Received on 2001-08-23