Hi Romulo,

Your patch looks ok. The threaded path will still be tested, therefore
no loss of functionality should occur. Testing non-threaded path will
be tricky, perhaps multiprocessing can help or if not a more creative
solution will be needed. Please send the pull request.

Oleg

On Sun, 9 Jun 2013 16:56:27 -0300
Romulo Ceccon <romuloceccon_at_gmail.com> wrote:

> Hello,
>
> I'm porting Python and pycURL to an embeded platform with no threads.
> I've patched pycURL to allow compilation when thread support is
> disabled in Python, but before making a pull request on
> https://github.com/p/pycurl I'd like to ask for some feedback here,
> because I don't know whether this has already been dicussed or is even
> a welcome change:
> https://github.com/romuloceccon/pycurl/commit/669a254e79b7be7a1d5982148051afd11d62b407
>
> Unfortunately I can't run the test-cases if Python doesn't have
> threads enabled because they need 'bottle', and 'bottle' needs
> threads!
>
> Regards,
> Romulo
> _______________________________________________
> http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-and-python

_______________________________________________
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-and-python
Received on 2013-06-13