It seems that I deleted the "moderated" message, instead of accepting it. So,
here it is.

-- 
Jean-Philippe Barrette-LaPierre
Maintener of cURLpp (http://rrette.com/curlpp)

attached mail follows:

On 21/04/2005, at 22:00, Jean-Philippe Barrette-LaPierre wrote:

>> I am doing some work for a customer and I have built curlpp on some
>> fairly antique Sun hardware running Solaris 5.6 with Sun's WorkShop C
>> and C++ compilers, version 6. These are pretty old (1998(!)).
>> Nonetheless, the bulk of curlpp was fine but there were a few issues
>> that I suspect have more to do with using a non-gcc based compiler
>> than
>> their antiquity.
>
> It's pretty impressive that this antique compiler can do partial
> template
> specialization.

It must have been fairly advanced in its day. This customer refuses to
update their software for some reason -- it's like the machine is
frozen in 1998!

>> They are:
>>
>> - extra semicolons in declarations (Form.hpp, Options.hpp,
>> StorageOptions.hpp)
>> - std::map.insert() doesn't take an advisory parameter for where to
>> insert (OptionList.cpp)
>> - I prefer obj->member to (*obj).member so I changed that (personal
>> preference) (OptionList.cpp)
>> - in OptionList::mapType, the index of the map is declared as "long"
>> but everywhere it is used it is a cURL::cURLoption so I corrected that
>> (OptionList.hpp)
>> - the interface to writeDebug() wanted a C-style binding but it was
>> getting a C++ binding (example03.cpp)
>>
>
> Patch applied on the curlpp-0_5_0-branch2

Thanks, I've downloaded that and am using it.

>> I also had to go through the Makefiles by hand and remove "-W -Wall
>> -Werror" from CXXFLAGS and CFLAGS. There doesn't seem to be a way of
>> avoiding those options being included even though the compiler is not
>> gcc and doesn't understand those flags.
>
> Just added an option to configure script (--disable-warnings)

I tried this and it still included "-Werror" in the Makefiles which I
had to remove manually.

Rather than specify this option, I think that the gcc specific warning
flags should only be enabled when the compiler has been verified to be
gcc rather than having to explicitly turn these flags off.

For this compiler, the appropriate option is probably "+w". However,
even without that the compiler issues warnings when compiling its own
standard library so I'm not sure how useful it really would be.

>> Aside from those fairly minor issues, it seems to work pretty well.
>> Thanks for your efforts!
>
> Thanks for your patch!

My pleasure, glad to be able to help and it's also great to see that
you've folded in what I've done into the next release so quickly.
Thank you.

May I ask a quick question? I'm trying to get the HTTP return status
code from a request. In the libcurl docs, I should be able to get this
by calling curl_easy_getinfo() with CURLINFO_RESPONSE_CODE. I can't
see a way to get at that using libcurlpp, I was wondering whether I'd
missed something or hasn't that been implemented (yet)?

Thanks.

        Ben.

_______________________________________________
cURLpp mailing list
cURLpp_at_rrette.com
http://www.rrette.com/mailman/listinfo/curlpp
Received on 2005-04-27