On Fri, 4 May 2012, Tatsuhiro Tsujikawa wrote:

First out, I've tried your updated patch series and it is really a major step
fotward and I would say that it is now almost ready for merge. A really good
job! I would say the only little drawback I found now is that there's a bunch
of #ifdefs for HAVE_LIBMETALINK in the code, but I find that a rather cheap
price and something we can work on decreasing over time.

See below for some further feedback.

I would also like to urge other readers of this list to try out Tatsuhiro's
work and post your opinions here!

>> for other documentation, eventually there should also be Metalink info in
>> 'man curl' and add Metalink info to 'curl --help' add Metalink to
>> "Features" list in 'curl --version' ? (I'm sure there's other places, but
>> those are a good start :)
>
> Yes, it is needed in the end.

Yes, the man page and --help additions will be needed, and adding it to the
--version outout will be helpful to users to figure out if their version
supports metalink.

> Not yet. Since checking checksum needs hash calculations and we depend on
> the library for them, I first check the current curl code where hash
> calculation is implemented.

The existing hash code is not exposed to the client code but is only libcurl
internal so far. We do have some code that we still re-use in curl from
libcurl under the hood that isn't using the API - just in the name of avoiding
code duplication - and there might be reasons to do this for some hash
functions as well. Although I'm not sure they are that easily shared like
this. It needs to be investigated closer.

> I think the behavior of checking hash and deciding re-download is debatable
> to suite curl project.

Hm. What would be the different alternatives here to select between you think?

BTW, as we are in a feature freeze until the next release your work will not
be merged and pushed to the main repository until after 7.26.0 is out (in a
few weeks).

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ:        http://curl.haxx.se/docs/faq.html
Etiquette:  http://curl.haxx.se/mail/etiquette.html