cURL / Mailing Lists / curl-users / Single Mail

curl-users

Re: [PATCH] Correctly interpret "-N" to disable buffering

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 8 Jun 2009 00:26:36 +0200 (CEST)

On Sun, 7 Jun 2009, Eric Wong wrote:

> -N means --no-buffer, but the original option name is --buffer.
> So we need to negate it one more time (or one less time).

Ah, thanks. Applied. It seems it got broken in the option name remake in
7.19.0...

> On a side note, would a patch to change the nobuffer code path to use plain
> write(2) be accepted? It would save some data copies to provide a small
> speedup.

You mean it avoids the copying fwrite() does internally, or what copying are
you referring to?

But sure, I could accept such a patch. I'm not actually sure why we use the
buffered output approach in the first place, but perhaps we gain something at
some points...

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-users
FAQ:        http://curl.haxx.se/docs/faq.html
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2009-06-08