> On Sun, Aug 17, 2008 at 10:59:34AM -0500, Andy Tsouladze wrote:
>>> @@ -1856,6 +1856,8 @@
>>>
>>> if(!$short) {
>>> printf "test %03d SKIPPED: $why\n", $testnum;
>>> + } else {
>>> + logmsg sprintf("test %03d...SKIPPED\n", $testnum);
>>> }
>>>
>>> return -1;
>
> This part of the patch will display a SKIPPED line even if it's for an
> innocuous reason, like a missing keyword. The point of the short option is
> to reduce the verbosity of the output, so I don't think this extra message
> is appropriate. If you need to see all the messages, then avoid the -s
> option. If it's truly a catastrophic problem, then an error message
> could be displayed at the source, but I wouldn't call failure to start
> stunnel catastrophic.

I know this. Please look at my reasoning, and if it is not convincing,
feel free to remove this part.

1. Consider my original problem. After successful test 298, next lines I
saw on my terminal were:

test 298...OK (292 out of 445, remaining: 01:00)
stunnel exited with 16777215!
RUN: failed to start the HTTPS server
test 350...FAILED

Naturally, my assumption was that test 350 failed _because_ of stunnel,
which was not the case. With "SKIPPED" enabled, I would have seen

test 298...OK (292 out of 445, remaining: 01:00)
stunnel exited with 16777215!
RUN: failed to start the HTTPS server
test 300...SKIPPED
test 301...SKIPPED
test 302...SKIPPED
test 303...SKIPPED
test 304...SKIPPED
test 305...SKIPPED
test 306...SKIPPED
test 307...SKIPPED
test 308...SKIPPED
test 309...SKIPPED
test 350...FAILED

This would have tipped me to the fact that stunnel failure was part of
test 300 and not 350.

2. It keeps counting correct. With many skipped tests, test count (in
parentheses) also skips. IMHO, a short "SKIPPED" is nicer ;)

Regards,

Andy

Dr Andy Tsouladze
Sr Unix/Storage SysAdmin
Information Resources
-------------------------------------------------------------------
List admin: http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-users
FAQ: http://curl.haxx.se/docs/faq.html
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2008-08-19