cURL / Mailing Lists / curl-users / Single Mail

curl-users

Re: Patch to make curl support file://upload/ resume

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 29 May 2007 09:27:00 +0200 (CEST)

On Tue, 29 May 2007, ·å Í¿ wrote:

> I am using curl with version 7.16.1 and I have finished a patch to make curl
> support upload resume over file protocol.

Thanks! Filling in the "feature gaps" is certainly useful.

> I have tested this patch as follows:

I have the following little nits about the patch implementation:

* it doesn't use the curl standard source indent levels and brace positions
* it uses calloc() and then free() when the struct would be better just
   allocated as an auto variable on the stack
* we need to use "struct_stat" instead of "struct stat" for portability
   purposes so that the code will work for large files all over

can you please adjust and resubmit?

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2007-05-29