curl-users
Re: Patch for DJGPP build
Date: Wed, 23 Nov 2005 21:59:38 -0800 (PST)
On Wed, 23 Nov 2005, Doug Kaufman wrote:
> On Wed, 23 Nov 2005, Daniel Stenberg wrote:
>
> > On Sun, 20 Nov 2005, Doug Kaufman wrote:
> >
> > > Attached are the patch and the script that I used to compile 7.15.0.
> > > I did this using the DOS versions of the autoconfigure tools,
> >
> > Thanks! Two quick questions on the contents:
> >
> > 1. The added 'ioctlsocket' function pointer instead of 'ioctl'. I figure you
> > need this done like that due to the #define ioctl() you added in
> > lib/setup.h? Wouldn't it be nicer and simpler if we instead made the call
> > in lib/transfer.c within parentheses like this:
> >
> > err = (data->set.ioctl) (data, CURLIOCMD_RESTARTREAD,
> > data->set.ioctl_client);
> >
> > And _not_ have that special struct member for DOS builds?
>
> That should work. I didn't think of parentheses to stop the
> substitution there. That looks much better. I'll try to recompile that
> way later today to make sure it works correctly.
Curl 7.15.0 compiles fine with this change and seems to work properly on
initial testing. Thanks for the suggested change to the patch. I am
attaching the revised patch.
Doug
-- Doug Kaufman Internet: dkaufman_at_rahul.net
- TEXT/PLAIN attachment: curl715a.pch