cURL / Mailing Lists / curl-users / Single Mail

curl-users

Re: Strange proxy hang

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 20 Dec 2001 16:37:15 +0100 (MET)

On Thu, 20 Dec 2001, Björn Stenberg wrote:

> Nailed it.
>
> The bug is in the command line/environment variable handling. url.c:1211
> sets conn->bits.httpproxy if data->change.proxy is true, i.e. if there's a
> -x flag on the command line. Later on you check for proxy enviroment
> variables, but forget to set the conn->bits.httpproxy flag.

*dang* very good chasing my little brother ;-)

> I'm not sure how you want this flag. Here's a fix that only sets if for
> http proxies. Maybe it's better to always set it?

Yeah, because we always use HTTP proxies, the <protocol>_proxy mainly lets
you select *which* http proxy based on protocol.

I suggest this simpler fix instead:

--- url.c 2001/12/17 23:02:23 1.180
+++ url.c 2001/12/20 15:34:59
@@ -1566,6 +1566,7 @@
           /* we have a proxy here to set */
           data->change.proxy = proxy;
           data->change.proxy_alloc=TRUE; /* this needs to be freed later */
+ conn->bits.httpproxy = TRUE;
         }
       } /* if (!nope) - it wasn't specified non-proxy */
     } /* NO_PROXY wasn't specified or '*' */

Could you verify this?

-- 
    Daniel Stenberg -- curl groks URLs -- http://curl.haxx.se/
Received on 2001-12-20