cURL / Mailing Lists / curl-users / Single Mail

curl-users

RE: hanging URL

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 26 Sep 2000 15:33:05 +0200 (MET DST)

On Tue, 26 Sep 2000, Priebe, Jason wrote:

> Upon my cursory examination of the code, I don't think that a complete
> rewrite is necessary to implement this fix. If you change lines 316-512
> of http.c to simply assemble a buffer with the HTTP request and then use
> a single sendf, I would think that would suffice.

You're right, it isn't a complete rewrite that's needed to introduce this. It
is more a matter of building a buffer instead of doing the current sendf()
calls.

What makes things tricky are POST and things that can be extremely large
portions of data and that really makes no sense to merge into a single chunk.
That has to be taken into consideration.

In fact, anything larger than 1460 bytes is highly unlikely to be kept in one
piece anyway due to the underlying layers.

> I'd be happy to help out with that. (It's been some time since I've done
> any heavy C coding, though. I'd hate to introduce a memory leak or a
> buffer overrun.)

I always tend to accept changes easier if I don't have to do them all by
myself. I'd be willing to accept changes that would add this behaviour to
curl and of course I'll also hang around to assist and verify that all
changes is consistent with the general design and that no obvious errors get
through.

If you produce the first initiative/patch, I'm sure we can cooperate to get
it working properly.

I do want to release 7.3 before this change gets incorporated.

-- 
  Daniel Stenberg -- curl project maintainer -- http://curl.haxx.se/
Received on 2000-09-26