Menu ▾ ▴

#1215 curl_easy_setopt(CURLOPT_COOKIELIST) does not take share lock

closed-fixed
Daniel Stenberg
cookies (5) share (1)
5
2013-06-21
2013-04-09
Benjamin Gilbert
No

It appears from an inspection of the libcurl source (curl-7_29_0-415-gf8da49e) that if a CURL * is using shared cookie data, curl_easy_setopt(curl, CURLOPT_COOKIELIST, ...) will modify the shared cookies without taking the share lock.

Discussion

  • Daniel Stenberg

    Daniel Stenberg - 2013-04-11

    Thanks for the report. Any chance you can write up a test recipe for this, possibly by extending test 506 or by writing something new based on that?

     

  • Daniel Stenberg

    Daniel Stenberg - 2013-04-11
    • assigned_to: Daniel Stenberg
     

  • Benjamin Gilbert

    Benjamin Gilbert - 2013-04-12

    I extended test 506; patch attached. Apologies for the unreadability of the test data diff; the sequence number changes rippled through the entire test.

     
    cookielist-share-lock-test.patch

  • Daniel Stenberg

    Daniel Stenberg - 2013-06-17
    • labels: --> cookies, share
    • status: open --> closed-fixed
     

  • Daniel Stenberg

    Daniel Stenberg - 2013-06-17

    Thanks a lot for your report and your patch. It took me a long time but now I've pushed a fix for this as commit 7ac3e9f1ba7c9.

    Case closed!