Menu

#1190 Fix socks proxy with noproxy matched

closed-fixed
5
2013-06-21
2013-02-10
Ulion
No

currently, if you set socks proxy with the noproxy matching target host, it will hang up since current code didn't check it and will still init a socks connection to the target url host:port.

I made a PR for fix it: https://github.com/xbmc/xbmc/pull/2167

Discussion

  • Daniel Stenberg

    Daniel Stenberg - 2013-02-10

    That link mentions a "message pump" on ios. Seems completely irrelevant...?

     
  • Ulion

    Ulion - 2013-02-10

    sorry for the miss pasted link, here's the one: https://github.com/bagder/curl/pull/56

    sf can not edit posted content, github is cool:)

     
  • Daniel Stenberg

    Daniel Stenberg - 2013-02-11
    • status: open --> closed-fixed
     
  • Daniel Stenberg

    Daniel Stenberg - 2013-02-11

    Thanks a lot, merged and pushed to git now. commit 5cd85db9faadc25d997f16880a14