mime: relax easy/mime structures binding #9927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
Nov 16, 2022
Can you please cite those changes as references in the commit, or just briefly explain what they are? |
monnerat
force-pushed
the
mime-no-data
branch
from
8a2f628
to
cc4a7c4
Compare
Done. |
Deprecation and removal of codeset conversion support from the library have released the strict need for an early binding of mime structures to an easy handle (curl@2610142). This constraint currently forces to create the handle before the mime structure and the latter cannot be attached to another handle once created (see https://curl.se/mail/lib-2022-08/0027.html). This commit removes the handle pointers from the mime structures allowing more flexibility on their use. When an easy handle is duplicated, bound mime structures must however still be duplicated too as their components hold send-time dynamic information.
monnerat
force-pushed
the
mime-no-data
branch
from
cc4a7c4
to
4b249c9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the library have released the strict need for an early binding of mime structures to an easy handle.
This constraint currently forces to create the handle before the mime structure and the latter cannot be attached to another handle once created (see https://curl.se/mail/lib-2022-08/0027.html).
This commit removes the handle pointers from the mime structures allowing more flexibility on their use.
When an easy handle is duplicated, bound mime structures must however still be duplicated too as their components hold send-time dynamic information.