Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket fixes for partial frames and buffer updates. #9890

Closed
wants to merge 2 commits into from
Closed

Websocket fixes for partial frames and buffer updates. #9890

wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Nov 11, 2022

  • buffers updated correctly when handling partial frames
  • callbacks no longer invoked for incomplete payload data of 0 length
  • curl_ws_recv no longer returns with 0 length partial payload

@icing
Websocket fixes for partial frames and buffer updates.
85f031a 
- buffers updated correctly when handling partial frames
- callbacks no longer invoked for incomplete payload data of 0 length
- curl_ws_recv no longer returns with 0 length partial payload
@icing
Fix for incorrect buf pointer in curl_ws_recv, introduced by PR.
2329d8d 
- renamed wsp->stillbuffer to wsp->stillblen
@bagder bagder closed this in 13d5502 Nov 11, 2022
@bagder
Copy link
Member

bagder commented Nov 11, 2022

Thanks!

@hnaderi hnaderi mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
WebSocket
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder