Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie: compare cookie prefixes case insensitively #9863

Closed
wants to merge 2 commits into from
Closed

cookie: compare cookie prefixes case insensitively #9863

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Nov 7, 2022

Adapted to language in rfc6265bis draft-11.

@bagder
cookie: compare cookie prefixes case insensitively
b57f4e5 
Adapted to language in rfc6265bis draft-11.
@bagder bagder added the HTTP label Nov 7, 2022
danielgustafsson
danielgustafsson approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be good to change a test case to have a mixed-case prefix just to keep us honest.

danielgustafsson
danielgustafsson approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bagder bagder closed this in 14061f7 Nov 8, 2022
@bagder bagder deleted the bagder/cookie-case-prefix branch November 8, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgustafsson danielgustafsson danielgustafsson approved these changes

Assignees
No one assigned
Labels
HTTP
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @danielgustafsson