lib: fix some type mismatches and remove unneeded typecasts #9835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2022
Many of these castings are unneeded if we change the variables to work better with each other. Ref: curl#9823 Closes #xxxx
bagder
reviewed
Oct 31, 2022
bagder
reviewed
Oct 31, 2022
MarcelRaad
approved these changes
Nov 1, 2022
| @@ -650,7 +650,7 @@ CURLcode Curl_http_auth_act(struct Curl_easy *data) | |||
| if(!data->set.str[STRING_BEARER]) | |||
| authmask &= (unsigned long)~CURLAUTH_BEARER; | |||
|
|
|||
| if(100 <= data->req.httpcode && 199 >= data->req.httpcode) | |||
| if(100 <= data->req.httpcode && data->req.httpcode <= 199) | |||
There was a problem hiding this comment.
Not sure what this is supposed to fix. The rest looks good to me!
There was a problem hiding this comment.
This one isn't supposed to fix anything it's just a style change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of these castings are unneeded if we change the variables to work better with each other.
Ref: #9823
Closes #xxxx
This is a subset of the changes submitted by @AtariDreams in #9823.