netrc: replace fgets with Curl_get_line #9789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the parser only accept complete lines and avoid problems with overly long lines. Reported-by: Hiroki Kurosawa
|
For info, this PR was included in curl 7.86.0 shipped with MacOS Ventura 13.2 (MacOS Ventura 13.1 had curl 7.85.0). But #9973 was not included on curl 7.86.0, so there is a bug about .netrc files not ending with newlines not being handled properly on mac venture 13.2. |
|
That sounds like an Apple problem. |
|
When I compile 7.86.0 on linux, there is this problem. it's a curl 7.86.0 problem. |
|
Sure, which is why we fixed the problem and included that in an update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the parser only accept complete lines and avoid problems with overly long lines.
Reported-by: Hiroki Kurosawa