Makefile.m32: reintroduce CROSSPREFIX and -W -Wall [ci skip] #9784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reintroduce `CROSSPREFIX`: If set, we add it to the `CC` and `AR` values, and to the _default_ value of `RC`, which is `windres`. This allows to control each of these individidually, while also allowing to simplify configuration via `CROSSPREFIX`. This variable worked differently earlier. Hopefully this new solution hits a better compromise in usefulness/complexity/flexibility. Follow-up to: aa970c4 - Enable warnings again: This time with an option to override it via `CFLAGS`. Warnings are also enabled by default in CMake, `makefile.dj` and `makefile.amiga` builds (not in autotools though). Follow-up to 10fbd8b Closes #xxxx
vszakats
force-pushed
the
m32-before-release
branch
from
6f408ed
to
d4b800a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce
CROSSPREFIX:If set, we add it to the
CCandARvalues, and to the default value ofRC, which iswindres. This allows to control each of these individidually, while also allowing to simplify configuration viaCROSSPREFIX.This variable worked differently earlier. Hopefully this new solution hits a better compromise in usefulness/complexity/flexibility.
Follow-up to: aa970c4
Enable warnings again:
This time with an option to override it via
CFLAGS. Warnings are also enabled by default in CMake,makefile.djandmakefile.amigabuilds (not in autotools though).Follow-up to 10fbd8b
Closes #xxxx