Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostip: guard PF_INET6 use #9760

Closed
wants to merge 1 commit into from
Closed

hostip: guard PF_INET6 use #9760

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

Some platforms (e.g. Amiga OS) do not have PF_INET6. Adjust the code for these.

hostip.c: In function 'fetch_addr':
hostip.c:308:12: error: 'PF_INET6' undeclared (first use in this function)
       pf = PF_INET6;
            ^~~~~~~~

Regression from 1902e8f

Closes #xxxx

@vszakats
hostip: guard PF_INET6 use
0606aa6 
Some platforms (e.g. Amiga OS) do not have `PF_INET6`. Adjust the code
for these.

```
hostip.c: In function 'fetch_addr':
hostip.c:308:12: error: 'PF_INET6' undeclared (first use in this function)
       pf = PF_INET6;
            ^~~~~~~~
```

Regression from 1902e8f

Closes #xxxx
@vszakats
Copy link
Member Author

vszakats commented Oct 18, 2022 •
edited

The initial patch fixes the compiler error, but it's most likely not the correct fix. Other variations may be using ENABLE_IPV6 instead, or excluding a larger block of code in this case.

This came up while cross-compiling for Amiga OS.

@vszakats vszakats added the build label Oct 18, 2022
@vszakats
Copy link
Member Author

/cc @dkarpov1970

@vszakats vszakats closed this in 1c567f7 Oct 18, 2022
@vszakats vszakats deleted the hostip-pfinet6 branch October 18, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build regression
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vszakats @bagder