Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngtcp2 compile error #9747

Closed
jurisuk opened this issue Oct 17, 2022 · 1 comment
Closed

ngtcp2 compile error #9747

jurisuk opened this issue Oct 17, 2022 · 1 comment
Labels
build HTTP/3 h3 or quic related

Comments

@jurisuk
Copy link

jurisuk commented Oct 17, 2022 

  CC       libcurl_la-curl_path.lo
  CC       libcurl_la-mqtt.lo
  CC       vquic/libcurl_la-ngtcp2.lo
vquic/ngtcp2.c: In function ‘ng_flush_egress’:
vquic/ngtcp2.c:1991:7: error: implicit declaration of function ‘ngtcp2_conn_get_max_udp_payload_size’; did you mean ‘ngtcp2_conn_get_max_tx_udp_payload_size’? [-Werror=implicit-function-declaration]
 1991 |       ngtcp2_conn_get_max_udp_payload_size(qs->qconn);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       ngtcp2_conn_get_max_tx_udp_payload_size
vquic/ngtcp2.c:1993:7: error: implicit declaration of function ‘ngtcp2_conn_get_path_max_udp_payload_size’; did you mean ‘ngtcp2_conn_get_path_max_tx_udp_payload_size’? [-Werror=implicit-function-declaration]
 1993 |       ngtcp2_conn_get_path_max_udp_payload_size(qs->qconn);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       ngtcp2_conn_get_path_max_tx_udp_payload_size
cc1: some warnings being treated as errors
make[2]: *** [Makefile:3109: vquic/libcurl_la-ngtcp2.lo] Error 1
make[2]: Leaving directory '/var/build-git2/curl/lib'
make[1]: *** [Makefile:1427: all] Error 2
make[1]: Leaving directory '/var/build-git2/curl/lib'
make: *** [Makefile:1239: all-recursive] Error 1
@bagder bagder changed the title Compile error ngtcp2 compile error Oct 17, 2022
@bagder bagder added build HTTP/3 h3 or quic related labels Oct 17, 2022
@jay
Copy link
Member

jay commented Oct 17, 2022

it was renamed to ngtcp2_conn_get_max_tx_udp_payload_size
ngtcp2/ngtcp2@b0d86f60

jay added a commit to jay/curl that referenced this issue Oct 17, 2022
@jay
ngtcp2: Fix build error due to change in ngtcp2 prototypes
fdf76b7 
ngtcp2/ngtcp2@b0d86f60 changed:

ngtcp2_conn_get_max_udp_payload_size =>
ngtcp2_conn_get_max_tx_udp_payload_size

ngtcp2_conn_get_path_max_udp_payload_size =>
ngtcp2_conn_get_path_max_tx_udp_payload_size

Reported-by: jurisuk@users.noreply.github.com

Fixes curl#9747
Closes #xxxx
@jay jay mentioned this issue Oct 17, 2022
Closed
jay added a commit to jay/curl that referenced this issue Oct 17, 2022
@jay
ngtcp2: Fix build errors due to changes in ngtcp2 library
ea15733 
ngtcp2/ngtcp2@b0d86f60 changed:

- ngtcp2_conn_get_max_udp_payload_size =>
  ngtcp2_conn_get_max_tx_udp_payload_size

- ngtcp2_conn_get_path_max_udp_payload_size =>
  ngtcp2_conn_get_path_max_tx_udp_payload_size

ngtcp2/ngtcp2@ec59b873 changed:

- 'early_data_rejected' member added to ng_callbacks.

Assisted-by: Daniel Stenberg
Reported-by: jurisuk@users.noreply.github.com

Fixes curl#9747
Closes #xxxx
jay added a commit to jay/curl that referenced this issue Oct 17, 2022
@jay
ngtcp2: Fix build errors due to changes in ngtcp2 library
4689081 
ngtcp2/ngtcp2@b0d86f60 changed:

- ngtcp2_conn_get_max_udp_payload_size =>
  ngtcp2_conn_get_max_tx_udp_payload_size

- ngtcp2_conn_get_path_max_udp_payload_size =>
  ngtcp2_conn_get_path_max_tx_udp_payload_size

ngtcp2/ngtcp2@ec59b873 changed:

- 'early_data_rejected' member added to ng_callbacks.

Assisted-by: Daniel Stenberg
Reported-by: jurisuk@users.noreply.github.com

Fixes curl#9747
Closes #xxxx
@jay jay closed this as completed in 6b066de Oct 17, 2022
jquepi pushed a commit to jquepi/curl.1.555 that referenced this issue Oct 24, 2022
@jay @jquepi
ngtcp2: Fix build errors due to changes in ngtcp2 library
2872858 
ngtcp2/ngtcp2@b0d86f60 changed:

- ngtcp2_conn_get_max_udp_payload_size =>
  ngtcp2_conn_get_max_tx_udp_payload_size

- ngtcp2_conn_get_path_max_udp_payload_size =>
  ngtcp2_conn_get_path_max_tx_udp_payload_size

ngtcp2/ngtcp2@ec59b873 changed:

- 'early_data_rejected' member added to ng_callbacks.

Assisted-by: Daniel Stenberg
Reported-by: jurisuk@users.noreply.github.com

Fixes curl/curl#9747
Closes curl/curl#9748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build HTTP/3 h3 or quic related
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ngtcp2: Fix build error due to change in ngtcp2 prototypes jay/curl
3 participants
@bagder @jay @jurisuk