tool_paramhelp: str2udouble 'max' changed to double #9700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The maximum accepted timeout value for connect timeout is set to be
|
|
Ok, I see. I will change it back to LONG_MAX/1000 |
|
Maybe it should be long all the way? |
It parses a double to allow fractions of seconds: |
|
I see.. I will think of a way to perhaps not compare a long to a double; that would be the only value in a PR like this hehe. |
|
I think this is as far as this PR can go! |
bagder
approved these changes
Oct 13, 2022
|
"This branch cannot be rebased due to conflicts" Can you please rebase on master, fix the issues and force-push? |
|
There it is! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is Hacktoberfest. I found myself here. Nitpicking in this glorious repository.
My LSP told me:
"Implicit conversion from 'long' to 'double' may lose precision"
I therefore thought that I perhaps could make a little PR.
Actually, with this PR; one may now be able to wait even longer for a connection to fail!
And that might also be a good thing.