Makefile.m32: drop CROSSPREFIX and manual CC/AR defaults [ci skip] #9698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aimed to fix a regression [0], where `CC` initialization moved beyond its first use. But, on closer inspection it turned out that the `CC` initialization does not work as expected due to GNU Make filling it with `cc` by default. So unless implicit values were explicitly disable via a GNU Make option, the default value of `$CROSSPREFIX` + `gcc` was never reached. At the same time the implicit value `cc` maps to `gcc` in (most/all?) MinGW envs. `AR` has the same issue, which has a default value of `ar`. We could reintroduce a separate variable name to fix this without ill effects, but for simplicity and flexibility, it seems better to drop support for `CROSSPREFIX`, along with our own `CC`/`AR` init logic, and require the caller to initialize `CC`, `AR` and `RC` to the full (prefixed if necessary) names of these tools, as desired. We keep `RC ?= windres` because `RC` is empty by default. Also fix grammar in a comment. [0] 10fbd8b
obonaventure
pushed a commit
to mptcp-apps/curl
that referenced
this pull request
Oct 12, 2022
This patch aimed to fix a regression [0], where `CC` initialization moved beyond its first use. But, on closer inspection it turned out that the `CC` initialization does not work as expected due to GNU Make filling it with `cc` by default. So unless implicit values were explicitly disabled via a GNU Make option, the default value of `$CROSSPREFIX` + `gcc` was never used. At the same time the implicit value `cc` maps to `gcc` in (most/all?) MinGW envs. `AR` has the same issue, with a default value of `ar`. We could reintroduce a separate variable to fix this without ill effects, but for simplicity and flexibility, it seems better to drop support for `CROSSPREFIX`, along with our own `CC`/`AR` init logic, and require the caller to initialize `CC`, `AR` and `RC` to the full (prefixed if necessary) names of these tools, as desired. We keep `RC ?= windres` because `RC` is empty by default. Also fix grammar in a comment. [0] 10fbd8b Closes curl#9698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aimed to fix a regression [0], where
CCinitialization moved beyond its first use. But, on closer inspection it turned out that theCCinitialization does not work as expected due to GNU Make filling it withccby default. So unless implicit values were explicitly disabled via a GNU Make option, the default value of$CROSSPREFIX+gccwas never used. At the same time the implicit valueccmaps togccin (most/all?) MinGW envs.ARhas the same issue, with a default value ofar.We could reintroduce a separate variable to fix this without ill effects, but for simplicity and flexibility, it seems better to drop support for
CROSSPREFIX, along with our ownCC/ARinit logic, and require the caller to initializeCC,ARandRCto the full (prefixed if necessary) names of these tools, as desired.We keep
RC ?= windresbecauseRCis empty by default.Also fix grammar in a comment.
[0] 10fbd8b