Set ARES_AI_NUMERICSERV hint flags when calling ares_getaddrinfo #9694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hint flag is ARES_AI_NUMERICSERV, and it will save a call to getservbyname or getservbyname_r to set it.
bsergean
changed the title
|
I think that the FreeBSD test failures are unrelated. |
Oh yes, they most definitely are unrelated. |
bagder
approved these changes
Oct 11, 2022
|
Thanks! |
|
Thanks for taking a look and merging ! |
obonaventure
pushed a commit
to mptcp-apps/curl
that referenced
this pull request
Oct 12, 2022
The hint flag is ARES_AI_NUMERICSERV, and it will save a call to getservbyname or getservbyname_r to set it. Closes curl#9694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hint flag is ARES_AI_NUMERICSERV, and it will save a call to getservbyname or getservbyname_r to set it.
This is where the hint flag is used in the C-Ares library -> https://github.com/c-ares/c-ares/blob/main/src/lib/ares_getaddrinfo.c#L645
For context we are trying to make a static binary that can run on any linux box, however that fails as not setting the hint triggers a getservbyname_r calls, which in turn loads the nss libraries which might not be on a different linux box (possible if that box runs alpine).