Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool: reorganize function c_escape around a dynbuf #9653

Closed
wants to merge 1 commit into from
Closed

tool: reorganize function c_escape around a dynbuf #9653

wants to merge 1 commit into from

Conversation

monnerat
Copy link
Contributor

@monnerat monnerat commented Oct 5, 2022

This is a bit shorter and a lot safer.

Substrings of unescaped characters are added by a single call to reduce overhead.

Extend test 1465 to handle more kind of escapes.

@monnerat
tool: reorganize function c_escape around a dynbuf
9f39232 
This is a bit shorter and a lot safer.

Substrings of unescaped characters are added by a single call to reduce
overhead.

Extend test 1465 to handle more kind of escapes.
bagder
bagder approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me like!

@bagder
Copy link
Member

bagder commented Oct 6, 2022

Thanks!

@bagder bagder closed this in 2e475de Oct 6, 2022
@monnerat monnerat deleted the escape branch October 6, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monnerat @bagder